fix(dpg): incorrect enum convenience/protocol parameter conversion#3898
Merged
archerzz merged 8 commits intoAzure:feature/v3from Nov 10, 2023
Merged
Conversation
- add missing logic to convert method parameter of int/float enum types from convenience to protocol - add temporary test case fix Azure#3881
archerzz
requested review from
ArthurMa1978,
hallipr,
jsquire,
lirenhe and
m-nash
as code owners
Member
Author
|
We need to add some test cases in |
chunyu3
approved these changes
Nov 3, 2023
Member
|
@archerzz Please add tests in cadl-ranch. |
JoshLove-msft
approved these changes
Nov 3, 2023
Member
Author
|
Regen Preview: Azure/azure-sdk-for-net#39720 No actual change |
Member
|
Can this be merged? |
ArthurMa1978
approved these changes
Nov 9, 2023
Member
Author
|
blocked by #3917 |
lirenhe
approved these changes
Nov 10, 2023
Member
Author
|
@JoshLove-msft This PR has been merged. It should unblock your work on the enum parameters. |
live1206
pushed a commit
to live1206/autorest.csharp
that referenced
this pull request
Dec 11, 2023
…zure#3898) - add missing logic to convert method parameter of int/float enum types from convenience to protocol - add temporary test case fix Azure#3881
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix #3881
Checklist
To ensure a quick review and merge, please ensure:
Ready to Land?